[Bug 198837] Review Request: eris - Client-side session layer for Atlas-C++

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eris - Client-side session layer for Atlas-C++
Alias: eris

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198837





------- Additional Comments From wart at kobold.org  2006-07-14 16:36 EST -------
(In reply to comment #1)
> ==== MUST ====
> - Remove pkgconfig from BuildRequries, this should be picked up by the devel
> packages
> - Fix changelog version number
> - "outpu" in description should be "output"

fixed, fixed, and fixed.

> - Why is glib-2.0 not added in BuildRequires?

I didn't see that it made any difference during the build, but I guess upstream
has it there for a reason.  Added.

> - Add a %check section

Added.  The first time I ran this on FC4-x86_64 in mock, the tests hung.  The
next few times it was ok.  I'll keep an eye on the build system and disable the
tests if they cause problems.

> - %doc in devel should be docs/html/*

Fixed.

http://www.kobold.org/~wart/fedora/eris-1.3.11-2.src.rpm
http://www.kobold.org/~wart/fedora/eris.spec


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.