[Bug 198878] Review Request: mutagen - Python module to handle audio metadata
bugzilla at redhat.com
bugzilla at redhat.com
Sat Jul 15 05:10:24 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: mutagen - Python module to handle audio metadata
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198878
panemade at gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |panemade at gmail.com
------- Additional Comments From panemade at gmail.com 2006-07-15 01:01 EST -------
== Not an official review as I'm not yet sponsored ==
Mock build for rawhide i386 is sucessfull
* MUST Items:
- rpmlint shows errors as
E: mutagen no-binary
W: mutagen wrong-file-end-of-line-encoding
/usr/share/doc/mutagen-1.5.1/TUTORIAL
E: mutagen non-executable-script
/usr/lib/python2.4/site-packages/mutagen/__init__.py 0644
- dist tag is present.
- The package is named according to the Package Naming Guidelines.
- The spec file name matching the base package mutagen, in the
format mutagen.spec.
- This package meets the Packaging Guidelines.
- The spec file for the package MUST be legible.
- The package is licensed with an open-source compatible license GPL.
- This package includes License file COPYING.
- This source package includes the text of the license in its own file,and
that file, containing the text of the license for the package is included in %doc.
- The sources used to build the package matches the upstream source,
as provided in the spec URL. md5sum is correct (9ce5d5f14e02f2eabd919d6bdaebadbc)
- This package successfully compiled and built into binary rpms for i386
architecture.
- This package did not containd any ExcludeArch.
- This package owns all directories that it creates.
- This package did not contain any duplicate files in the %files
listing.
- This package have a %clean section, which contains rm -rf
$RPM_BUILD_ROOT.
- This package used macros.
- Document files are included like COPYING, NEWS, README, TUTORIAL.
- Package did NOT contained any .la libtool archives.
Also,
* Source URL is present and working.
* BuildRoot is correct BuildRoot:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
What you Need to Do:-
I think you dont need following line if you are building for only fc5
Requires: python-abi = %(%{__python} -c "import sys ; print sys.version[:3]")
BuildRequires: python-devel
also try to clean %files section of SPEC as
%files
%defattr(-,root,root,-)
%doc COPYING NEWS README TUTORIAL
%{_bindir}/*
%{_mandir}/man*/*gz
%dir %{python_sitelib}/mutagen
%{python_sitelib}/mutagen/*.py
%{python_sitelib}/mutagen/*.pyc
%ghost %{python_sitelib}/mutagen/*.pyo
I removes those above Requires and modified %files as shown above and package
built without any problem.
For rpmlint errors,
E: mutagen no-binary
There is no mutagen named binary when i did python setup.py build in Source
W: mutagen wrong-file-end-of-line-encoding /usr/share/doc/mutagen-1.5.1/TUTORIAL
I check TUTORIAL file but did not understood what is the problem.
E: mutagen non-executable-script
/usr/lib/python2.4/site-packages/mutagen/__init__.py 0644
I found other python packages are also having same
__init__.py 0644 permissions. so why rpmlint report problem i confuesd?
can anyone comment on this issues?
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list