[Bug 197967] Review Request: gkrellm - Multiple stacked system monitors in one process

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gkrellm - Multiple stacked system monitors in one process


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197967


ville.skytta at iki.fi changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink at leemhuis.info |ville.skytta at iki.fi
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From ville.skytta at iki.fi  2006-07-15 05:07 EST -------
- "standard" BuildRoot not used
- useradd/groupadd dependencies missing
- chkconfig dependencies should be context marked, and chkconfig called 
  consistently (with full path)
- using a macro for %{flags} seems a bit odd, normal shell variables should work 
  just fine
- %{?_smp_mflags} missing
- could use %{_initrddir} for the init script location
- could use init script directly in %preun daemon
- "SMP CPU" sounds odd in the description (gkrellm does UP CPU too), and it
  could be improved a bit otherwise too

Will attach a patch for the above.

Another random note (for upstream?):

- gkrellm.pc doesn't look very useful at the moment.  For plugin/theme packages
  it would be nice to have the lib and data dirs defined in it, for example by
  adding pkgdatadir=%{_datadir}/gkrellm2 and pkglibdir=%{_libdir}/gkrellm2 in
  it; then those could be queried like pkg-config gkrellm --variable=pkglibdir

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.