[Bug 197967] Review Request: gkrellm - Multiple stacked system monitors in one process

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gkrellm - Multiple stacked system monitors in one process


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197967





------- Additional Comments From j.w.r.degoede at hhs.nl  2006-07-15 07:01 EST -------
(In reply to comment #5)
Thanks for the patch, I've applied it, but I've undone this:

> - could use init script directly in %preun daemon
I agree, but for cases where a full example is given on the ScriptletSnippets
wiki page, I always use the code from the wiki in the name of consistency across
FE as a whole. And the ScriptletSnippets wiki page uses /sbin/service:
http://fedoraproject.org/wiki/ScriptletSnippets

Also the current code in the wiki doesn't use " || :", so neither does this
version of gkrellm (for the service stuff), that can be fixed if you want though.

> Another random note (for upstream?):
> 
> - gkrellm.pc doesn't look very useful at the moment.  For plugin/theme packages
>   it would be nice to have the lib and data dirs defined in it, for example by
>   adding pkgdatadir=%{_datadir}/gkrellm2 and pkglibdir=%{_libdir}/gkrellm2 in
>   it; then those could be queried like pkg-config gkrellm --variable=pkglibdir

I'll send this upstream.

(In reply to comment #7)
> Oh, and gkrellmd should be condrestarted on -daemon upgrades.  I'd also add LSB
> action aliases to the init script (try-restart -> condrestart, force-reload ->
> restart).

Done and done.

New version at:
Spec URL: http://people.atrpms.net/~hdegoede/gkrellm.spec
SRPM URL: http://people.atrpms.net/~hdegoede/gkrellm-2.2.9-6.src.rpm

Changes:
* Sat Jul 15 2006 Hans de Goede <j.w.r.degoede at hhs.nl> 2.2.9-6
- Various specfile improvements by Ville Skyttä (ville.skytta at iki.fi)
- Make the daemon package scripts match the ScriptletSnippets wiki page
- Add LSB aliases (try-restart, force-reload) to the -daemon initscript
- Add %%{?dist} to the release for consistency with other packages I maintain



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.