[Bug 198878] Review Request: mutagen - Python module to handle audio metadata

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mutagen - Python module to handle audio metadata


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198878





------- Additional Comments From paul at city-fan.org  2006-07-15 09:50 EST -------
(In reply to comment #4)
> Thanks for review this package.
> 
> The line:
> Requires:   python-abi = %(%{__python} -c "import sys ; print sys.version[:3]"
> is from fedora-rpmdevtools template so I didn't change it and, as I see, other 
> SPEC files also has this line so I don't delete it.

The python spec template will soon be fixed to get rid of this:

http://www.redhat.com/archives/fedora-extras-list/2006-July/msg00557.html

If you check the "requires" of the built package on FC4 or later, you should
find a dependency on "python(abi) = 2.4" automatically added by RPM, making the
python-abi dependency in the spec file redundant.

> E: mutagen non-executable-script ...
> The first line of file is
> #! /usr/bin/env python
> and for this reason rpmlint treat this file as executable but it shouldn't be 
> executable. I think we can leave it alone.

rpmlint knows it's not executable but thinks that it's a script (which it isn't)
because of the "#! /usr/bin/env python" as you say. You can shut rpmlint up by
editing the first line out of the affected files in the %prep stage of the spec.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.