[Bug 199029] Review Request: jokosher

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: jokosher


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199029





------- Additional Comments From peter at thecodergeek.com  2006-07-16 19:11 EST -------
According to Yum, gnonlin is not in Core, Updates, or Extras, so this package -
with regards to Extras - would not be self-supporting in that it would need a
dependency external to the default repositories. Perhaps you'd also want to
submit Gnonlin for inclusion into Extras as well?

Also, you should not use the Packager: tag in your spec. See:
http://fedoraproject.org/wiki/Packaging/Guidelines#head-c17fb8c1ce9be40da720a2b25d1e2a241062038f

Thirdly, your package would probably break on 64-bit systems, as you hardcode
/lib/ into the path of %_pythondir. Please use a macro for this instead, such as
%{_lib} (or %{_libdir}, etc. as needed). 

Forth, you really should be using %{python_sitedir} and following the %files
section correctly as mentioned in Packaging/Python on the Wiki. See:
http://fedoraproject.org/wiki/Packaging/Python

Lastly, in the %changelog, you simply have a user at host identifier. I'm not
certain, but I believe that this is supposed to be a full and valid email
address (such as "me at my-isp.com" or something similar).

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.