[Bug 198881] Review Request: perl-POE-Filter-IRCD

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-POE-Filter-IRCD


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198881


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From tibbs at math.uh.edu  2006-07-18 12:09 EST -------
Ralf, honestly, please stop hammering on the packagers and get the Perl specfile
template changed instead.  Maybe make fedora-newrpmspec call into cpanspec
instead, which will not generate the bits you object to for noarch packages. 
I'm not going to block on anything that's just following the template that we
put in place for them to follow.

Chris, thanks for clarifying the license issue after our discussion on IRC.

Review:
* source files match upstream:
   30ab7c5504eb6d99c7d3da399933efac  POE-Filter-IRCD-1.7.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.
* latest version is being packaged.
O BuildRequires are proper (BR: perl is unnecessary)
O Compiler flags are appropriate (no need to pass them to the makefile of a
noarch package)
* %clean is present.
* package builds in mock (development, x86_64).
* rpmlint is silent.
* noarch package, no debuginfo.
* final provides and requires are sane:
   perl(POE::Filter::IRCD) = 1.7
   perl-POE-Filter-IRCD = 1.7-0.fc6
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(Carp)
   perl(base)
   perl(strict)
   perl(vars)
   perl(warnings)
* %check is present and all tests pass:
   All tests successful.
   Files=1, Tests=7,  0 wallclock secs ( 0.02 cusr +  0.01 csys =  0.03 CPU)
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.