[Bug 198882] Review Request: perl-POE-Component-IRC

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-POE-Component-IRC


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198882





------- Additional Comments From rc040203 at freenet.de  2006-07-21 04:17 EST -------
You guys might want to learn about rpmbuild's --with/--without options.

This provides much easier means to enable conditional parts of a spec than using
brute force hacks like this __with_network_tests.



--- perl-POE-Component-IRC.spec 2006-07-21 05:08:25.000000000 +0200
+++ perl-POE-Component-IRC.spec.hacked  2006-07-21 10:25:01.000000000 +0200
@@ -1,8 +1,7 @@
 # Note:  The tests for this perl dist. are disabled by default, as they
 # require network access and would thus fail in the buildsys' mock
 # environments.  To build locally while enabling tests, either:
-#   rpmbuild ... --define '__with_network_tests 1' ...
-#   define __with_network_tests 1 in your ~/.rpmmacros
+#   rpmbuild ... --with network_tests

 Name:           perl-POE-Component-IRC
 Version:        4.96
@@ -55,9 +54,7 @@

 %check
 # tests require network access, disabled by default
-%if %{?__with_network_tests}
-make test
-%endif
+%{?_with_network_tests:make test}


 %clean

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.