[Bug 191130] Review Request: kmobiletools

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kmobiletools


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191130


michael at knox.net.nz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink at leemhuis.info |michael at knox.net.nz
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From michael at knox.net.nz  2006-07-21 04:48 EST -------
Hello.. I will review this package for you.. 

----------------------------------------

Review for release 2:

* RPM name is OK
* Source kmobiletools-0.4.3.3.tar.bz2 is the same as upstream
* This is the latest version
* Builds fine in mock
* rpmlint looks OK
* File list looks OK

Needs work:
* Scriptlets: missing "gtk-update-icon-cache" in %post (wiki: ScriptletSnippets)
* Scriptlets: missing "gtk-update-icon-cache" in %postun (wiki: ScriptletSnippets)

Package looks pretty good. If you fix up the %post/%postun scriplets, I can
approve this submission. 



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.