[Bug 199784] Review Request: psycopg2 - A PostgreSQL database adapter for Python

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: psycopg2 - A PostgreSQL database adapter for Python


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199784





------- Additional Comments From devrim at commandprompt.com  2006-07-22 08:48 EST -------
Hi,

(In reply to comment #4)
> You changed name of package, but you forgot to change name in subpackage doc.
> It is nice to use macros in it:
> Requires: %{name} = %{version}-%{release}

Thanks for the prompt. I've applied the change.

> Next thing of the doc subpackage is its group. According to Packaging
> Guidelines the Group name of doc subpackage should be Documentation, not
> Applications/Databases.

Thanks, change applied.

> From the main package you can delete python dependency, because rpm
> automatically adds it (I forgot about it, yesterday).

Yeah, that's what I noticed yesterday after reading Python Guideline. Thanks
again, I've deleted it.
 
> The last thing is about doc subpackage again. I think it should be
> noarch, but then package won't compile well. Maybe, someone more experienced
> in reviewing would give you a good advice.

Per recent discussing in the list, I'm ignoring this.

Regards,Devrim

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.