[Bug 199192] Review Request: kadu - Gadu-Gadu client for online messaging

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kadu - Gadu-Gadu client for online messaging


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199192





------- Additional Comments From Axel.Thimm at ATrpms.net  2006-07-23 08:16 EST -------
MUST items
==========

- rpmlint output (see below): not OK
+ package name: OK
- (latest) spec file name (0.5.0-0.1.20060716svn.spec): not OK, please use
  kadu.spec again
+ license is open source: OK
+ license in sources (GPL2) and license in specfile (GPL) match: OK
- license (COPYING) included, but not in %doc: not OK (?)
o American English: OK (but there is a trivial typo: s/Develpoments/Development/
  in %description devel and missing "by" at some "made by" in other
  descriptions)
+ specfile legible: OK (but see comments below)
- sources match upstream: not OK
  http://www.kadu.net/download/snapshots/kadu-20060716.tar.bz2 doesn't exist
  anymore
+ compiles and build into binary rpms: OK on i386
+ sane BRs: OK
+ locales: OK (doesn't use locale folder directly, installs in private 
  location)
+ ldconfig usage: OK (none neccessary, no shared libs under %{_libdir})
+ owns its directories: OK
+ %files duplicate: OK (none reported)
- permissions: not OK (see below)
+ %clean section: OK
+ system macros: OK (used)
+ contains code: OK
+ doc subpackage: OK (not needed)
+ %doc contents do not influence runtime: OK
+ devel package (contents): OK
+ devel package (dependencies): OK
+ %{name}.desktop/desktop-file-install: OK

rpmlint:
========
errors:
E: kadu-debuginfo empty-debuginfo-package
E: kadu explicit-lib-dependency libsndfile

warnings:
W: kadu-alsa_sound no-documentation
W: kadu-alsa_sound unstripped-binary-or-object /usr/lib64/kadu/modules/alsa_sound.so
W: kadu-amarok no-documentation
W: kadu-amarok unstripped-binary-or-object /usr/lib64/kadu/modules/amarok.so
W: kadu-arts_sound no-documentation
W: kadu-arts_sound unstripped-binary-or-object /usr/lib64/kadu/modules/arts_sound.so
W: kadu-dcopexport no-documentation
W: kadu-dcopexport unstripped-binary-or-object /usr/lib64/kadu/modules/dcopexport.so
W: kadu-devel no-documentation
W: kadu-esd_sound no-documentation
W: kadu-esd_sound unstripped-binary-or-object /usr/lib64/kadu/modules/esd_sound.so
W: kadu-exec_notify no-documentation
W: kadu-exec_notify unstripped-binary-or-object
/usr/lib64/kadu/modules/exec_notify.so
W: kadu-ext_info no-documentation
W: kadu-ext_info unstripped-binary-or-object /usr/lib64/kadu/modules/ext_info.so
W: kadu-filedesc no-documentation
W: kadu-filedesc unstripped-binary-or-object /usr/lib64/kadu/modules/filedesc.so
W: kadu-iwait4u no-documentation
W: kadu-iwait4u unstripped-binary-or-object /usr/lib64/kadu/modules/iwait4u.so
W: kadu-led_notify no-documentation
W: kadu-led_notify unstripped-binary-or-object /usr/lib64/kadu/modules/led_notify.so
W: kadu-miastoplusa_sms no-documentation
W: kadu-miastoplusa_sms unstripped-binary-or-object
/usr/lib64/kadu/modules/miastoplusa_sms.so
W: kadu mixed-use-of-spaces-and-tabs
W: kadu no-documentation
W: kadu setup-not-quiet
W: kadu-spellchecker no-documentation
W: kadu-spellchecker unstripped-binary-or-object
/usr/lib64/kadu/modules/spellchecker.so
W: kadu-tabs no-documentation
W: kadu-tabs unstripped-binary-or-object /usr/lib64/kadu/modules/tabs.so
W: kadu-theme-crystal16 no-documentation
W: kadu-theme-crystal22 no-documentation
W: kadu-theme-gg6_compatible no-documentation
W: kadu-theme-glass16 no-documentation
W: kadu-theme-glass22 no-documentation
W: kadu-theme-nuvola16 no-documentation
W: kadu-theme-nuvola22 no-documentation
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/account_management.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/arts_sound.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/autoaway.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/autoresponder.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/config_wizard.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/dcc.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/default_sms.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/dsp_sound.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/encryption.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/ext_sound.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/hints.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/migration.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/sms.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/voice.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/window_notify.so
W: kadu unstripped-binary-or-object /usr/lib64/kadu/modules/x11_docking.so
W: kadu-weather no-documentation
W: kadu-weather unstripped-binary-or-object /usr/lib64/kadu/modules/weather.so
W: kadu-xmms no-documentation
W: kadu-xmms unstripped-binary-or-object /usr/lib64/kadu/modules/xmms.so

comments:
=========

- build should include debugging symbols, e.g. the buildlog has:
>   Compile with debug symbols:         no
  Please compile with debug symbols and let rpm automagically extract them out
  into the debuginfo package.

- permissions of shared libs should be executable to allow for debuginfo 
  extraction

- "Requires: libsndfile" is not neccessary (unless it needs something from
  %{_bindir}/sndfile-* at runtime

- "mixed-use-of-spaces-and-tabs": Use emacs to tabbify/untabbify the specfile

- "%setup -D -T -n kadu" is missing "-q"

- "unstripped-binary-or-object": Fix by making the modules executable either 
  with chmod at the end of %install of with %attr/%defattr

- self-defined macros: In general I'm not against self-defined macros to make 
  packages more flexible or legible. In this case some macros make the specfile 
  harder to read than neccessary for example _kadudir being %{_datadir}/kadu.
  I wouldn't call this a blocker, but I would recommend to unwrap most of these
  macros to increase legibility.

Please install rpmlint on your system and use it on the packages while
developing the specfile.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.