[Bug 189315] Review Request: ardour

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ardour


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189315





------- Additional Comments From seg at haxxed.com  2006-07-24 02:02 EST -------
Alright, lets see if we can get this in before FC4 goes into maintenance mode.

rpmlint on the src.rpm says:

W: ardour rpm-buildroot-usage %build rm -f
$RPM_BUILD_ROOT%{_libdir}/ardour/libardour*
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
will break short circuiting.

I'm really not sure what this command even accomplishes. Old cruft? Delete it.

E: ardour tag-not-utf8 %changelog
E: ardour non-utf8-spec-file ardour.spec

The changelog is a mess. No blank lines between the older entries, etc. I'm
thinking maybe you should just cut off all the old CCRMA entries, which would
make the encoding errors moot. They seem to be mostly irrelevant to the current
state of the package except for the explanation of the NOARCH and ARCH options
which should be retained as a comment up in the %build section.

W: ardour macro-in-%changelog find_lang
W: ardour macro-in-%changelog _sysconfdir

Remember you need to escape macros in the changelog, i.e. %%find_lang. Or just
drop the % entirely.

I see an %{__install} macro in there, which is inconsistent. There's also some
%{name} macros in there I'd personally lose.

I wouldn't bother packaging the README, it contains basically nothing of use.

The following buildreqs do not seem to be necessary: bison, byacc, flex,
linuxdoc-tools, curl-devel

The %files section could use some cleanup. Put trailing slashes on the
directories, and I'd recommend getting rid of the globbing. And get rid of the
%{name} macro.

During the build, RPM warns of files listed twice. Add %dir to
%{_sysconfdir}/ardour to fix it.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.