[Bug 199780] Review Request: dstat

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dstat


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199780





------- Additional Comments From paul at all-the-johnsons.co.uk  2006-07-24 11:45 EST -------
Looking at the spec file you've got there, I can't see anything which bytecode
compiles the python. Remember a # before anything is just counted as a comment
and rpmbuild skips past it as if it wasn't there.

A couple of other niggles

In the Source: you have .../dstat/dstat-%{version}...

This can be substituted with .../%{name}/%{name}-%{version}. I know on packages
I've had reviewed on, this has been brought up.

The make install line can just be

make DESTDIR=%{buildroot} install - you don't need the quotes around the buildroot

Does the package come with any language translation files?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.