[Bug 188461] Review Request: xmms-musepack - Mpegplus (mpc) playback plugin for XMMS

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xmms-musepack - Mpegplus (mpc) playback plugin for XMMS


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188461





------- Additional Comments From matthias at rpmforge.net  2006-07-25 04:13 EST -------
Yes, gcc-c++ will be removed. But as for the others :
- Nothing in the guideline forces to quiet the %setup step.
- BuildRoot is fine, guidelines only hint a "preferred" value. I keep needing to
  repeat over and over that I find it plain silly to execute "id" in there, since
  we're building in a dedicated build system anyway, always as the same user.
This is quite OT for the review, but IMHO both the quiet %setup and the
BuildRoot should be things that should be configured with sane defaults outside
of the spec files, for which repeating in each and every spec file should *not*
be needed...

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.