[Bug 189662] Review Request: transconnect -- A function imposter to allow transparent connection over HTTPS proxies

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: transconnect -- A function imposter to allow transparent connection over HTTPS proxies


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189662





------- Additional Comments From enrico.scholz at informatik.tu-chemnitz.de  2006-07-25 09:13 EST -------
* Tue Jul 25 2006 Enrico Scholz <enrico.scholz at informatik.tu-chemnitz.de> - 1:1.3-0.3.Beta
- removed the %(id -u) from the buildroot; it adds unneeded clutter,
  is not required and you gain nothing with it
- fixed paths in 'tconn.cat'
- enhanced 'README.fedora'

http://ensc.de/fedora/transconnect/


======


> > - follow Fedora naming guidelines strictly; increased epoch
> 
> This package have never been released, you don't need to increase
> the epoch?

Needed as upgrade path on my systems; you want to follow the guidelines
strictly and these guidelines do not forbid epoch...


> > no; I like it this way
> 
> Indeed, but if I'm not wrong 
> %{!?release_func:%global release_func() %1%{?dist}}
> Release:        %release_func 0.2.Beta
> 
> leads to the much simpler
> Release:        0.2.Beta%{?dist}
> 
> so why not use the simpler way?

* I like it
* it is used in all my other packages
* it does not violate the guidelines


> * I think it would be nice if you dropped a line somewhere (in
>   README.fedora?) explaining that tconn-localres.so corresponds
>   with the make localres case described in the INSTALL file, or
>   something along those lines.

ok; added some lines



> * I also think that the file tconn.cat could be modified such that
> export LD_PRELOAD=$HOME/.tconn/tconn.so
>   is replaced by
> export LD_PRELOAD=%{_libdir}/tconn.so

ok; is now 'LD_PRELOAD=tconn.so'


> * I know that some reviewer disagree on having modules to be
>   dlopened directly in %_libdir and insist on having dlopened
>   modules in subdirs of %_libdir.

'tconn.so' will not be dlopen()'ed but LD_PRELOAD'ed. Placing into the
searchpath allows

| LD_PRELOAD=tconn.so

without specifying the full path. Therefore, I will keep it in %_libdir.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.