[Bug 193897] Review Request: mysql-connector-java - Official JDBC driver for MySQL

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mysql-connector-java - Official JDBC driver for MySQL


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193897





------- Additional Comments From green at redhat.com  2006-07-25 14:57 EST -------
Hi Igor.  I went through the review list.  Please see the lines with "X".

MUST Items:
 - rpmlint output is clean
 - package name is fine for now (although debate continue on "jpp" usage)
 - The spec file name matches the base package %{name}, in the format %{name}.spec
 - The package meets the Packaging Guidelines.
 - The package license is OK: (I think) GPL + headache inducing exception text.
X- The License field says GPL, which I think it fair since I think
   you're allowed to ignore the exception.  However, the license text
   (COPYING) has the old FSF address. Please update the address and
   file a bug upstream.
 - The license text is in %doc
 - The spec file is written in American English.
X- The spec file for the package is legible, although it would be nice
   to line up field names and values in columns, rather than have them
   ragged.
X- The guidelines say "The sources used to build the package must
   match the upstream source, as provided in the spec URL. Reviewers
   should use md5sum for this task." however we need to remove jar
   binaries before packaging to comply with LGPL.
X- Fails to build in in mock.
   Cannot find build req  jta >= 0:1.0.1-0.a.1. Exiting.
   $ rpm -q --whatprovides jta
   geronimo-specs-compat-1.0-0.M2.2jpp_7fc
   I don't know what the right solution here is.  Replace jta with
geronimo-specs-compat?
X- BuildRequires need adjusting. (see mock build failure, above)
 - Package is not relocatable.
 - Package owns all directories in creates.
 - No duplicate files in %files.
 - File permissions look good.
 - %clean section is good.
X- macro use is fine apart from %{__sed}.  Please use "sed".
 - package contains code (no "content")
X- %doc section seems to contain equivalent README/README.txt files in
   top level and docs dir.  Please clean this up.  Also, what is with the
  "@MYSQL_CJ_VERSION@" in the README files?
 - %doc contents don't affect runtime
 - package does not own files/dirs owned by other packages.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.