[Bug 196177] Review Request: kdmtheme - Theme Manager for KDM

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: kdmtheme - Theme Manager for KDM


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196177





------- Additional Comments From rdieter at math.unl.edu  2006-07-25 16:20 EST -------
* Upstream SOURCE matches:
40bacda700e847aab7070babc15f67ca  kdmtheme-1.1.2.tar.bz2

* builds/installs clean.

1. For URL, I'd recommend instead using
http://beta.smileaf.org/projects/
or
http://www.kde-look.org/content/show.php?content=22120

2.  Don't omit the %{_libdir}/kde3/kcm*.la file.  It's needed.  (It doesn't work
for me without it).

3.  You ought to
Requires: kdebase
since this is a KControl module (and kcontrol is in kdebase).

4. (optional) configure optimization flags:
%configure \
  --enable-new-ldflags \
  --disable-debug --disable-warnings \
  --disable-dependancy-tracking --enable-final
(probably not a big deal since this is just a small kcontrol module)

Fix up 1-3, and I'll approve this.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.