[Bug 200051] Review Request: libutempter

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libutempter


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200051





------- Additional Comments From mharris at redhat.com  2006-07-25 17:20 EST -------
(In reply to comment #2)
> Spec looks pretty good, here is some rpmlint output:
> 
> E: libutempter-debuginfo tag-not-utf8 %changelog
> E: libutempter-devel tag-not-utf8 %changelog

Bero's last name was in ISO8859-1 in a changelog entry.  Worked around via
anglicization.

 
> Find the offending changelog entry
> 
> E: libutempter non-standard-dir-perm /usr/libexec/utempter 0710

Dir restricted to group utempter access for security.

> E: libutempter non-standard-executable-perm /usr/libexec/utempter/utempter 02711
> E: libutempter non-standard-executable-perm /usr/libexec/utempter/utempter 02711

Binary restricted to group utempter, with perms for SGID binaries.

> E: libutempter non-standard-gid /usr/libexec/utempter utempter

This needs to be created once the package is approved, which it sounds
like now from above. ;o)

> E: libutempter non-standard-gid /usr/libexec/utempter/utempter utmp

setuid utmp executable.  The GID should be allocated already, if not
I'll have to do that, but I assume it is, since RH utempter uses the
same GID.


> I'm assuming because this has to run as utmpter and this is ignorable.

yup
 
> E: libutempter non-utf8-spec-file libutempter.spec
> 
> Because of the changelog

yup, fixed.
 
> E: libutempter setgid-binary /usr/libexec/utempter/utempter utmp 02711
> 
> Again because of utempter, ignore.

yup
 
> E: libutempter tag-not-utf8 %changelog
> E: libutempter tag-not-utf8 %changelog
> 
> Changelog again.

Wow, it reports the same problem 3 different errors for the same issue.

> W: libutempter-devel no-documentation

Correct, there is no documentation except the README and COPYING.  The rpmlint
developers are free to submit manpages however.  ;o)
 
> W: libutempter macro-in-%changelog _libdir
> W: libutempter macro-in-%changelog _libdir
> W: libutempter macro-in-%changelog _sbindir
> 
> These are probably ignorable as well.

Actually I just noticed them a half hour ago or so and fixed them.
Theoretically %_libdir et al. should always expand to a path of some
form, however it is also theoretical that they could expand to something
else, and macros are illegal in the changelog, so fixed.
 
> Everything else looks OK, so approving.

Good beans.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.