[Bug 199780] Review Request: dstat

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dstat


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199780





------- Additional Comments From toshio at tiki-lounge.com  2006-07-25 19:01 EST -------
* The files don't get moved into _docdir until after %install.  So instead of
operating on %{buildroot}/%{_docdir}/* you want to operate on the files in your
source tree.

* You've commented out the %clean section.  You'll want to put that back.
* There are other pieces of commented code that could be removed:
  #BuildRequires:..
  #Requires:....
  #/usr/lib/rpm/brp-python-bytecompile....
  #%config(noreplace) %{_sysconfdir}/dstat.conf....

You can leave them in with explanations if you think they make the spec clearer
and easier to understand (I see that you have commented on two of those listed
already.  The choice is yours.)

* For every release bump, there must also be a changelog entry.  So instead of
just bumping the release number on the changelog line, add a whole new entry
that tells what you've changed.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.