[Bug 192606] Review Request: yafc: yet another ftp client

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: yafc: yet another ftp client


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192606





------- Additional Comments From rc040203 at freenet.de  2006-07-26 01:46 EST -------
(In reply to comment #5)
> rpmlint result:
> E: yafc zero-length /usr/share/doc/yafc-1.1.1/doc/yafc.info
> 
> The package does indeed contain an empty compressed file yafc.info.gz.

The cause is building triggers regeneration of the *.info while "makeinfo" is
missing.

/builddir/build/BUILD/yafc-1.1.1/support/missing: line 46: makeinfo: command not
found
WARNING: `makeinfo' is missing on your system.  You should only need it if
         you modified a `.texi' or `.texinfo' file, or any other file
         indirectly affecting the aspect of the manual.  The spurious
         call might also be the consequence of using a buggy `make' (AIX,
         DU, IRIX).  You might want to install the `Texinfo' package or
         the `GNU make' package.  Grab either from any GNU archive site.

=> BR: /usr/sbin/makeinfo
could be applied to work around this issue.


But .. the actual cause is deeper: The tarball is not packaged properly.
It contains a raw preconfigured CVS snapshot with all temporary files and broken
timestamps inside.

Due to this I strongly recommend to add a 
make distclean
to %prep to assure the subsequent %configure doesn't "reconfigure" the source
tree, but to configure it anew.

Further issues:

* You put *.texi's in %doc. These *.texi's are the sources of yafc.info. It
doesn't make much sense to put them into %docdir

* Related to the previous issue, the "prepare for %doc" block doesn't seem
useful to me. The package ships and installs mans and infos, its Makefiles
handle them correctly. There is no for any special treatment.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.