[Bug 174021] Review Request: aplus-fsf - Advanced APL Interpreter

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: aplus-fsf - Advanced APL Interpreter


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174021


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From tibbs at math.uh.edu  2006-07-26 21:57 EST -------
Hey, you managed to fix those undefined-non-weak-symbol errors.

I see only two things:

W: aplus-fsf incoherent-version-in-changelog 4.20-2.5 4.20.2-5.fc6
  I think you meant to use "4.20.2-5" and not "4.20-2.5".
  You should probably change ":" to "-" in your initial changelog entry as well.

You have "BuildRequires: xterm" when you should have "Requires: xterm".  The
point is to make sure that xterm is there when the package is installed, because
that's what the Xterm-apl app-defaults file is for.

So there's really nothing substantive wrong at this point.  I'll go ahead and
approve; if you agree with the above fixes then go ahead and make them and check in.

APPROVED, provided you make the above changes.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.