[Bug 189188] Review Request: sqlgrey - postfix grey-listing policy service

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sqlgrey - postfix grey-listing policy service


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189188


michael at knox.net.nz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink at leemhuis.info |michael at knox.net.nz
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From michael at knox.net.nz  2006-07-26 22:19 EST -------
I will review this one. 

----------------------------------------
Review for release 2:

* RPM name is OK
* This is the latest version
* Builds fine in mock (rawhide)
* rpmlint failed
* File list looks OK
* Config files of sqlgrey looks OK

Needs work:
* Encoding should be UTF-8

Some of the changelog entries contain the name "�stein Viggen" which is tripping
this rpmlint error. 

* there must be a proper %clean section
  (wiki: Packaging/ReviewGuidelines)

You %clean section should look like:

%clean
rm -rf $RPM_BUILD_ROOT

not:

%clean
make clean

* Spec file: some paths are not replaced with RPM macros
  (wiki: QAChecklist item 7)

You should use "%{_initrddir}" instead of "%{_sysconfdir}/init.d/"

* No downloadable source. Please give the full URL in the Source tag.

You should use "http://download.sourceforge.net/%{name}/%{name}-%{version}.tar.gz 

* The BuildRoot must be cleaned at the beginning of %install

You need to add "rm -rf $RPM_BUILD_ROOT" before you run make install

* The package should contain the text of the license
  (wiki: Packaging/ReviewGuidelines)

There is a COPYING file in the tarball. Please add this to the %docs

rpmlint of sqlgrey:
W: sqlgrey non-conffile-in-etc /etc/sqlgrey/README

This shouldn't be there? 

E: sqlgrey init-script-without-chkconfig-postin /etc/init.d/sqlgrey
E: sqlgrey init-script-without-chkconfig-preun /etc/init.d/sqlgrey

You should atleast use chkconfig to add the init script. 

W: sqlgrey no-reload-entry /etc/init.d/sqlgrey
W: sqlgrey service-default-enabled /etc/init.d/sqlgrey
E: sqlgrey subsys-not-used /etc/init.d/sqlgrey

The init script is not very Fedora friendly. Perhaps a new one should be created
and supplied? 


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.