[Bug 199029] Review Request: jokosher

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: jokosher


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199029





------- Additional Comments From snecklifter at gmail.com  2006-07-27 14:42 EST -------
(In reply to comment #9)

> %{name}-%{version}.tar.gz (or sometimes with something after %{version} such as
> -rc2.tar.gz). This is what Source has to point to.

Fixed.

(In reply to comment #10)

> You're missing some requires as well - check http://www.jokosher.org/download
> for details.

Fixed. Alsaaudio is not a strict requirement for the operation of jokosher and
the next version will not require it at all. However I will consider packaging
it if necessary.

(In reply to comment #11)

* I suggest that upstream do not modify/extend/sublicence the GPL with
exceptions, but rather put their distribution licence terms into a separate
file.

I have mentioned this on the development list.

* Run rpmlint on the binary rpm. From the two errors it reports, one is valid.

Now fixed.

* Directory /usr/lib/python2.4/site-packages/jokosher/ is not included.

Please could you clarify.

* Why is it arch-specific and not "BuildArch: noarch"?

Now fixed.

* Upstream recommends GStreamer 0.10.9 or above and prefers a CVS snapshot.
Requires: gstreamer >= 0.10.8 does not reflect that.

Now fixed.

* Prefer "install -p" over "cp" to preserve time-stamps of files.

Now fixed - yes this is much better, thanks.

* Run-time warning:

Some functionality will not work correctly or at all.

You must have the Python alsaaudio package installed.
Please install python-alsaaudio or fetch from http://www.wilstrup.net/pyalsaaudio/.

See above.

* Crashes reproducibly with below message. Steps to reproduce:

1) Start "jokosher"
2) Enter "Preferences".
3) Click "Close".
4) Click "Create a new project".

Starting up
/usr/lib/python2.4/site-packages/jokosher/Jokosher.py:1054:
GtkDeprecationWarning: gtk.threads_init is deprecated, use gtk.gdk.threads_init
instead
  gtk.threads_init()
6783: assertion failed "allocator->lock == mutex" file "dbus-dataslot.c" line 82
function _dbus_data_slot_allocator_alloc
Aborted

I cannot reproduce this however I am running the latest gstreamer and gnonlin
releases although I fail to see how that would alter things. This has not been
reported on the support forums or lists to my knowledge. Perhaps the latest spec
file and requires fixes this. py-dbus maybe?

(In reply to comment #12)

> The more I look into this package, the more odd it becomes.

> There is nothing (I can see) on the website as to the license
> Upstream recommending a cvs snapshot (moving target problems)

Gstreamer have now made a release so no longer dependent on cvs. Gnonlin also
anticipated doing the same in the near future however again, current gnonlin
will work, just not with full features.

> Upstream not sticking totally to the GPL

This has been mentioned to the devs. I would appreciate comments on how much of
a showstopper this is and how to get around it of there is no altering the
stance of how it is licensed upstream.

> Sure, it looks a nice package, but as it stands, is it stable (upstream) enough
> to be in Extras?

I would say yes in the spirit of release early and often. This is not an
admittance of buggy software - the two main issues users currently experience
are due to current version of gstreamer and gnonlin, both of which Requires
indicates.

> The functionality issues in #11 give me serious reasons to doubt it's inclusion
> at this time (though this could be down [again] to upstream or non-inclusion of
> R's on the rpm itself)

I hope the above gives you cause to re-think. I would be happy to see it wait
until fc6 for inclusion. Thanks again for the advice.

Regards
Chris

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.