[Bug 200374] Review Request: qstat - Real-time Game Server Status for Quake servers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: qstat - Real-time Game Server Status for Quake servers


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200374


wart at kobold.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|bugzilla-sink at leemhuis.info |wart at kobold.org
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From wart at kobold.org  2006-07-27 17:08 EST -------
A few small points before I get to a full review:

You don't need the check for "/" when you clean the buildroot in %install and
%clean.  A simple rm -rf will suffice:
rm -rf %{buildroot}

The -n %{name}-%{version} is unnecessary.  %setup already uses this as a default.

The %attr statements for qstat.cfg and the qstat binary are also not necessary
as these permissions/ownership are already used.

qstat can be used for more than just quake servers, so remove 'quake' from the
summary line.  You could replace it with 'FPS game' instead.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.