[Bug 199029] Review Request: jokosher

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: jokosher


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199029





------- Additional Comments From snecklifter at gmail.com  2006-07-27 17:58 EST -------
(In reply to comment #16)
> If the way the GPL is messed with adds restrictions, it causes major problems.
> If it removes restrictions, that's fine. My reading is it adds.

If the exceptions are placed into a separate file, would this resolve the
matter? My reading is that it permits people to use non-GPL compatible plugins
and therefore is not adding restrictions but IANAL.

> 
> The problem with release often and early is that you get releases which haven't
> had the time to mature and be debugged correctly. I've known of many security
> problems with that system.

The only comment I can make here is that this version has few known bugs and
most of those are outside of its control. One reason the package is being pushed
for inclusion in Extras is so that upstream can garner more feedback and improve
Q.A. which will surely help with debugging. As for security problems I really
cannot comment except to say this is an audio editor written in python using Gtk
widgets, not say, a driver with kernel hooks.

> 
> "* Directory /usr/lib/python2.4/site-packages/jokosher/ is not included.
> 
> Please could you clarify."
> 
> The application creates a directory (via the define) in the
> python/site-packages/ directory called jokosher. You need in your %files
> 
> %{python_dir}/site-packages/jokosher

Fixed.

> 
> "> You're missing some requires as well - check http://www.jokosher.org/download
> > for details.
> 
> Fixed. Alsaaudio is not a strict requirement for the operation of jokosher and
> the next version will not require it at all. However I will consider packaging
> it if necessary."
> 
> Depending on the timeframe of this packages possible acceptance into FE, I'd
> look into importing it. It won't harm.

A small patch (which only just missed the 0.1 release deadline) has now removed
this dependency on alsaaudio. 

http://jokosher.python-hosting.com/changeset/466

I have updated the package and spec file accordingly and bumped the version.

> 
> I can also replicate the dbus error on my 64 and 32 bit systems. This will need
> to be looked into.

I have posted on this and will get back to you. Would you please in the meantime
avail us of your dbus version which you can get with:

$ python -c "import dbus; print dbus.version"

Regards
Chris

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.