[Bug 200565] Review Request: ksynaptics - KDE configuration for synaptics module

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ksynaptics - KDE configuration for synaptics module


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200565


rdieter at math.unl.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink at leemhuis.info |rdieter at math.unl.edu
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From rdieter at math.unl.edu  2006-07-28 14:15 EST -------
upstream source checks out.
c9c124ba59bbb898bfc73f2ab00e8006  ksynaptics-0.3.1.tar.bz2

A few initial comments:

1.  Icons need scriptlets (See 
http://www.fedoraproject.org/wiki/ScriptletSnippets), something like:

%post
touch --no-create %{_datadir}/icons/hicolor || :
gtk-update-icon-cache -q %{_datadir}/icons/hicolor 2>/dev/null ||: 

%postun

2.  You don't really need:
export QTLIB=${QTDIR}/lib QTINC=${QTDIR}/include
anymore, the qt bug that this worked around is now fixed.
touch --no-create %{_datadir}/icons/hicolor || :
gtk-update-icon-cache -q %{_datadir}/icons/hicolor 2>/dev/null ||:

Otherwise it looks good!  Now, I'll try building and see how it works... (:



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.