[Bug 199679] Review Request: pgpool - Connection pooling/replication server for PostgreSQL

bugzilla at redhat.com bugzilla at redhat.com
Fri Jul 28 22:26:50 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pgpool - Connection pooling/replication server for PostgreSQL


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199679


cweyl at alumni.drew.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cweyl at alumni.drew.edu




------- Additional Comments From cweyl at alumni.drew.edu  2006-07-28 18:17 EST -------
A couple thoughts:

* With the usage of %configure in %build, you can drop "--bindir=%{_bindir} ..."
from that line (%configure includes them)
* I'm not sure of the best practice in this area myself, but it would seem to
make sense to put a .conf.sample file in %doc, rather than %{_sysconfdir}; maybe
either placing a default config in there (minus the .sample) or %ghost'ing
%{_sysconfdir}/pgpool.conf.  (/me invites comments)


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list