[Bug 183322] Review Request: conexus (network and serial I/O library with Gtkmm widgets)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: conexus (network and serial I/O library with Gtkmm widgets)


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=183322





------- Additional Comments From paul at all-the-johnsons.co.uk  2006-07-29 19:31 EST -------
make DESTDIR=%{buildroot} install

Again, be consistent with your macros

%{__rm} -rf %{buildroot}%{_bindir}

Why?

%{__cp} -arv docs/reference/html .

As with papyrus, can you include a comment on this

%{_libdir}/pkgconfig/*

No. For pkgconfig please use the name of the spec. I know you're using generic
templates for these, but where possible, include the names of libraries,
binaries and spec files.

%configure --enable-static=no

(niggle) %configure --disable-static not permitted (usually is)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.