[Bug 199797] Review Request: auriferous - Game inspired by the classic Loderunner

bugzilla at redhat.com bugzilla at redhat.com
Mon Jul 31 00:29:48 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: auriferous - Game inspired by the classic Loderunner


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=199797





------- Additional Comments From wart at kobold.org  2006-07-30 20:20 EST -------
GOOD
====
* rpmlint output clean
* package and spec file named appropriately
* spec file legible and in Am. English
* GPL license ok, license file included
* Compiles in mock on FC5-i386, FC5-x86_64,
* No extra BR:
* Source matches upstream:
  660447c44af5cee7543de57cc9dcafc6  auriferous-1.0.1.tar.bz2
* No locales
* No shared libaries
* Not relocatable
* RPM_BUILD_ROOT cleaned where necessary
* macro usage consistent
* Contains code and permissible content (game data)
* No need for -doc subpackage
* No need for -devel subpackage
* .desktop file installed correctly
* Does not own directories that it should not.
* Runs on FC5-i386

MUSTFIX
=======
* Missing BR: libpng-devel, or is this supposed to be pulled in
  automatically by ClanLib06-devel?

SHOULD
======
* Too many smileys in the %description.
* Consider moving %{_datadir}/auriferous to a -data subpackage

NOTES
=====
* The display size is slightly larger than my 800x600 setup, making it
  somewhat awkward.  I didn't see any in-game options to change the display
  size, is that possible?
* What's the difference between playerr.png in the tarball and your
  modified playerr.png?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list