[Bug 200665] Review Request: ltris

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ltris


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200665


wart at kobold.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wart at kobold.org




------- Additional Comments From wart at kobold.org  2006-07-31 01:27 EST -------
Requires: SDL_mixer can be dropped.  The package already requires
libSDL_mixer-1.2.so.0()(64bit), which is provided by SDL_mixer.

ltris.png is a 48x48 color icon.  Why not put it in the
$RPM_BUILD_ROOT/%{_datadir}/icons/hicolor/48x48/apps/ directory?  I've seem
packages use both, and I'm not sure which is the preferred location for desktop
icons.

You define _localstatedir, but never use it.  Drop the %define.

World writable scoreboard files are bad.  I would suggest either of the following:
1) Make the game setgid 'games' and make the scoreboard file 'games' group
writable.  Be sure to audit and modify the code to make sure that it's setgid safe.
2) Move the scoreboard file to $HOME so that it's private for each user.  This
removes the need to use a setgid binary, but also disables having a shared
scoreboard file.

Package creates but doesn't own '/var/games/%{name}'.  Since there's only one
file in this directory, it's acceptable (but not required) to put the scoreboard
file directly in /var/games without the %{name} subdirectory.  I'll update the
Games packaging guidelines to reflect this.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.