[Bug 191606] Review Request: lineak_kdeplugins - KDE-based actions for lineakd

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: lineak_kdeplugins - KDE-based actions for lineakd


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191606


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From tibbs at math.uh.edu  2006-06-01 15:05 EST -------
Oddly, if you run rpmlint on the src.rpm, it complains about /lib being
hardcoded; I guess it just does a search for "/lib" and finds your call to sed.

Other than that, rpmlint is silent.

Review:
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* source files match upstream:
   4ddfc475e4df27f8822e0b08c0f701b5  lineak_kdeplugins-0.8.4.tar.gz
   4ddfc475e4df27f8822e0b08c0f701b5  lineak_kdeplugins-0.8.4.tar.gz-srpm
* latest version is being packaged.
* BuildRequires are proper.
* package builds in mock (development, x86_64).
* rpmlint is silent.
 final provides and requires are sane:
   amarokplugin.so()(64bit)
   jukplugin.so()(64bit)
   kdesktopplugin.so()(64bit)
   kmailplugin.so()(64bit)
   kmixplugin.so()(64bit)
   konqplugin.so()(64bit)
   kscdplugin.so()(64bit)
   lineak_kdeplugins = 0.8.4
   lineak-kdeplugins = 0.8.4-4.fc6
  -
   kdelibs
   libICE.so.6()(64bit)
   libSM.so.6()(64bit)
   libX11.so.6()(64bit)
   libXext.so.6()(64bit)
   libdl.so.2()(64bit)
   libgcc_s.so.1()(64bit)
   libkdecore.so.4()(64bit)
   libkdeui.so.4()(64bit)
   libkio.so.4()(64bit)
   liblineak.so.0()(64bit)
   libm.so.6()(64bit)
   libpng12.so.0()(64bit)
   libpthread.so.0()(64bit)
   libqt-mt.so.3()(64bit)
   libstdc++.so.6()(64bit)
   libstdc++.so.6(CXXABI_1.3)(64bit)
   libstdc++.so.6(GLIBCXX_3.4)(64bit)
   libz.so.1()(64bit)
   lineakd = 0.8.4
* shared libraries are present, but internal to lineakd so no need to call ldconfig.
* package is not relocatable.
* owns the directories it creates (the plugins directory is created by lineakd,
which is a dependency).
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is not present; no test suite upstream.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.