[Bug 191507] Review Request: wifi-radar

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wifi-radar


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191507





------- Additional Comments From i.pilcher at comcast.net  2006-06-01 16:24 EST -------
(In reply to comment #1)
> There are a few minor issues with this package:

Hmm.  rpmlint appears to give useful output when run against an installed
package, but not when run against an SRPM file.  Interesting.

> - The package needs to properly handle its desktop file: 
> http://fedoraproject.org/wiki/Packaging/Guidelines#desktop

Done, but...

This confuses me.  From what I can tell, the desktop-file-install command
on the Wiki page simple prepends "fedora-" to the name of the desktop file
and adds the "X-Fedora" category.  What's the reason that a package can't
simply supply a desktop file that already meets the naming/category
requirements?

> Don't forget to include BuildRequires: desktop-file-utils

Done.

> W: wifi-radar conffile-without-noreplace-flag /etc/wifi-radar/wifi-radar.conf
> 
> Might not be a bad idea to set this as %config(missingok,noreplace) to keep some
> other package from stepping on this config file.

Done.

> E: wifi-radar non-readable /etc/wifi-radar/wifi-radar.conf 0600
> 
> I'm pretty sure you didn't intend this. Or did you?

WEP keys go in the config file, so I don't want it to be world-readable.
(Although, anyone who can run the application will be able to read them.)

> E: wifi-radar non-standard-dir-perm /etc/wifi-radar 0700
> 
> Also a weird permission set for the config directory.

If root creates a brand new config file (with a text editor, for example) it
will be 0644.  Making the directory 0700 keeps this from exposing any WEP
keys.

> E: wifi-radar non-standard-dir-perm /usr/share/doc/wifi-radar-1.9.6 0644

Fixed.

> I don't see the reason to deviate from the standard %doc permission set, even
> though 644 is valid.

Not really useful for a directory, though.  :-)

> Show me a new spec with the minor blockers listed above resolved and I'll
> sponsor/approve.

Updated SPEC file and SRPM at:

  http://home.comcast.net/~i.pilcher/wifi-radar.spec
  http://home.comcast.net/~i.pilcher/wifi-radar-1.9.6-2.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.