[Bug 191607] Review Request: lineak_xosdplugin - Onscreen display support for lineakd

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: lineak_xosdplugin - Onscreen display support for lineakd


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191607


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From tibbs at math.uh.edu  2006-06-01 19:58 EST -------
The issue was simply a missing BuildRequires: libXt-devel; I'll add it and
proceed with the review.

Note that the ChangeLog file has zero length and should not be packaged:

E: lineak-xosdplugin zero-length /usr/share/doc/lineak-xosdplugin-0.8.4/ChangeLog

These are pretty quick fixes, so I'll go ahead and approve and you can fix them
when you check in.

Review:
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* source files match upstream:
   36f519b21e7c7257bd9af6543f7fd9fc  lineak_xosdplugin-0.8.4.tar.gz
   36f519b21e7c7257bd9af6543f7fd9fc  lineak_xosdplugin-0.8.4.tar.gz-srpm
* latest version is being packaged.
O BuildRequires are proper (after adding libXt-devel as above).
O package builds in mock (development, x86_64) (after fixing BRs.)
X rpmlint complains about ChangeLog.
* final provides and requires are sane:
   lineak_xosdplugin = 0.8.4
   xosdplugin.so()(64bit)
   lineak-xosdplugin = 0.8.4-4.fc6
  -
   libX11.so.6()(64bit)
   libXext.so.6()(64bit)
   libXinerama.so.1()(64bit)
   libdl.so.2()(64bit)
   liblineak.so.0()(64bit)
   libxosd.so.2()(64bit)
   lineakd = 0.8.4
   xosd >= 2.1
* one shared library is present, but it is internal to lineakd and so there's no
need to call ldconfig.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is not present; no test suite upstream.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

APPROVED, but please don't package the zero length ChangeLog and don't forget to
add the BR: libXt-devel so the package will build.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.