[Bug 193804] Review Request: glitz
bugzilla at redhat.com
bugzilla at redhat.com
Fri Jun 2 02:52:37 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: glitz
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193804
------- Additional Comments From rc040203 at freenet.de 2006-06-01 22:44 EST -------
Some comments:
* IMO, it should be considered to split this package into 2 subpackages: glitz
and glitz-glx, because the package internally consists of libglitz and several
backends, with libglitz-glx being one them.
Splitting it would allow more fine-grained deps, and thereby would help avoid
unnecessary deps of apps/libs based on glitz.
* The deps of the devel package don't seem to be correct:
- libglitz doesn't seem to depend on any X or GL library.
- libglitz-glx seems to depend libX11-devel and libGL-devel, but not on further
libX*-devel, in particular it doesn't not depend on libXt-devel.
* The package ships manpages, but doesn't install them. May-be it's worth
considering to install them.
* The configure script carries several options defaulting to true:
--disable-glx Disable glitz's GLX backend
--disable-agl Disable glitz's AGL backend
--enable-egl Enable glitz's EGL backend
--disable-wgl Disable glitz's WGL backend
This will render building this package outside of a chroot-environment
non-deterministic, should one of these GL backends land in Fedora.
I.e. I recommend to add
--enable-glx --disable-agl --disable-egl --disable-wgl to %configure
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list