[Bug 189713] Review Request: gnubg

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnubg


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189713





------- Additional Comments From j.w.r.degoede at hhs.nl  2006-06-03 03:46 EST -------
MUST:
=====
* rpmlint output is:
   W: gnubg file-not-utf8 /usr/share/man/man6/gnubg.6.gz
   W: gnubg-databases no-documentation
   W: gnubg-sounds no-documentation
 You must fix the not utf8 error, you can do so by running iconv
 on the uncompressed manpage, see gcompris for an example. Notice that the
 original encoding may be different then in gcompris though (probably not).
* Package and spec file named appropriately
* Packaged according to packaging guidelines
* License (GPL) ok, license file included
* spec file is legible and in Am. English.
* Source matches upstream
* Compiles and builds on devel-x86_64
* BR: see below
* No locales
* no shared libs
* Not relocatable
* Package owns / or requires all dirs
* No duplicate files & Permissions ok
* %clean & macro usage OK
* Contains code only
* %doc does not affect runtime, and isn't large enough to warrent a sub package
* no -devel needed
* gui .desktop required but none included! must fix!


MUST fix:
=========
* building on devel gives:
 error: Installed (but unpackaged) file(s) found:
   /usr/share/info/dir
 This file should be removed at the end of %install
 Be sure to use "rm -f" for the removal since in my experience this file
 doesn't get created on all Fedora versions.
* Remove bogus "BuildRequires: gtk+-devel" this is a gtk2 app, gtk+-devel
 is for gtk1 apps.
* gtk2-devel implies freetype-devel, remove Extranous freetype-devel BR.
* esound-devel implies audiofile-devel, remove Extranous audiofile-devel BR.
* Add a desktop file and icon, see njam(.spec) for an example on howto
  properly install the .desktop file and the icon and howto properly update the
  icon cache on install / remove.


Should fix:
===========
* I get this during the build:
   /bin/sh: gnubg.weights: No such file or directory
   make[2]: [gnubg.wd] Error 1 (ignored)
 Yet you've included a a gnubg.weights as Source1, appearantly its not put
 in the right place.
* And this:
   cp: cannot stat /usr/share/texinfo/texinfo.dtd': No such file or directory
 But this one can brobably be ignored I can't find texinfo.dtd anywhere on
 my fairly complete install. Notice that gnubg itself does contain and
 installs a texinfo.dtd
* You can write things like:
   %dir %{_datadir}/gnubg/met 
   %{_datadir}/gnubg/met/*    
 As just:
   %{_datadir}/gnubg/met
 And the same for:
   %dir %{_datadir}/gnubg/scripts
   %{_datadir}/gnubg/scripts/* 
 Which can be just:
   %{_datadir}/gnubg/scripts
 Etc.
 And probably the same for:
   %dir %{_datadir}/gnubg/doc 
   %{_datadir}/gnubg/doc/*.png
   %{_datadir}/gnubg/doc/texinfo.dtd
   %{_datadir}/gnubg/doc/gnubg.xml
 Which can probably be written as just:
   %{_datadir}/gnubg/doc

Explain:
========
* Why add --without-board3d, gtkglext(-devel) is available in FE.
* Why the seperate database and soundpackages, does the main package
  function without these?



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.