[Bug 192876] Review Request: V2Strip ID3v2(Mp3 Files) tags remover

bugzilla at redhat.com bugzilla at redhat.com
Mon Jun 5 20:13:05 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: V2Strip ID3v2(Mp3 Files) tags remover


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192876


tcallawa at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|bdpepple at ameritech.net      |tcallawa at redhat.com
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From tcallawa at redhat.com  2006-06-05 16:05 EST -------
Good:

- rpmlint checks return nothing! :)
- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

Short, sweet, simple.
APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list