[Bug 189374] Re-Review Request: jed: an editor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Re-Review Request: jed: an editor


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189374


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From tibbs at math.uh.edu  2006-06-05 22:01 EST -------
Everything looks good, execpt that you don't use the dist tag.  (Sorry I didn't
notice it earlier; that's why I always run through my checklist.)  It's not an
absolute requirement but it's very strongly recommended.

If you don't mind my asking, how did you get rid of rpath?  I assume it's in the
multilib patch; is it the third hunk?

Since the only issue is the dist tag I'll go ahead and approve.  Normally I'd
say you can fix it when you check in, but it's already checked in, so I suppose
you can fix it at your leisure.

Review:
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
X dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* source files match upstream:
   5378c8e7805854018d9ec5c3cfadf637  jed-0.99-18.tar.bz2
   5378c8e7805854018d9ec5c3cfadf637  jed-0.99-18.tar.bz2-srpm
* latest version is being packaged.
* BuildRequires are proper.
* package builds in mock (development, x86_64).
* rpmlint is silent.
* final provides and requires are sane:
   jed-common
   jed-xjed
   jed = 0.99.18-4
  =
   libselinux.so.1()(64bit)
   libslang.so.2()(64bit)
   libslang.so.2(SLANG2)(64bit)
   libutil.so.1()(64bit)
   libutil.so.1(GLIBC_2.2.5)(64bit)
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is not present; no test suite upstream
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.