[Bug 193806] Review Request: libsvg

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libsvg


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193806


bugs.michael at gmx.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163776                      |163779
              nThis|                            |
       External Bug|https://bugzilla.redhat.com/|
          Reference|bugzilla/show_bug.cgi?id=192|
                   |432                         |




------- Additional Comments From bugs.michael at gmx.net  2006-06-07 14:51 EST -------
> checking for pkg-config... no

Missing 'BuildRequires: pkgconfig' 


> BuildRequires:  libpng-devel, libjpeg-devel, libxml2-devel, zlib-devel
>>>
> %package        devel
>>>
> Requires:       libpng-devel, libjpeg-devel, libxml2-devel, zlib-devel

Oh, it uses libjpeg and libpng headers, but doesn't link to the libs.
I suggest you mention that as a comment in the .spec file, as libsvg
users must link to these libs then (cf. pkg-config file dependencies!).

In this case, "Requires: pkgconfig" is a MUST for the -devel package.


File 'INSTALL' in %doc is of no interest to package users.
Don't include it.


$ cat libsvg-0.1.4.tar.gz.md5 
ce0715e3013f78506795fba16e8455d3  libsvg-0.1.4.tar.gz


With those minor changes: APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.