[Bug 193929] Review Request: knetstats

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: knetstats


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193929


j.w.r.degoede at hhs.nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |j.w.r.degoede at hhs.nl




------- Additional Comments From j.w.r.degoede at hhs.nl  2006-06-08 06:21 EST -------
Hi Chitlesh,

I see (from google) that you're already active in other area's fo the Fedora
project, good! As such I'm willing to sponsor you, but first you must show some
more / better understanding of the FE packaging guidelines.

There are 2 ways to show this better understanding:
1) You review a couple of packages from others see bug 163776 for a list of
   Review Requests that need a Reviewer, don't worry about not being competent
   enough todo a review, just add me to the CC-list and I'll watch over your 
   back.
2) Create some more packages and put me in the CC for the Review Request

Or (probably the best) a combination of these 2.

Now some remarks related to this review:
(In reply to comment #4)
> Thanks for such a reply,
> 
> I have updated the spec file with respect to what have been documented above
except:
> 
> No. 7.
> 
> Because I was unable to get scons root access/permissions while its execution.
> 
You really _must_ fix this, the trick is not to give scons root permission, but
to change the build so that it doesnot try to install files outside of the buildroot

> No. 9.
> Because It automatically adds itself to the kmenu->Internet. Do I have to use
> desktop-file-utils nevertheless ?

Yes, and since it already puts the .desktop file under /usr/share/applicatiuons
you should use the --delete-original option to desktop-file-install.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.