[Bug 191538] Review Request: qsynth - Qt based Fluidsynth GUI front end
bugzilla at redhat.com
bugzilla at redhat.com
Thu Jun 8 17:28:39 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: qsynth - Qt based Fluidsynth GUI front end
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191538
------- Additional Comments From green at redhat.com 2006-06-08 13:20 EST -------
Hi Fernando. Here are some comments. Some of these may seem nit-picky - sorry
about that...
* Release should use %{?dist}
* Alignment is inconsistent with rest of Fedora, so..
Summary: Qt based Fluidsynth GUI front end
Name: qsynth
Version: 0.2.5
..should be...
Summary: Qt based Fluidsynth GUI front end
Name: qsynth
Version: 0.2.5
* Some people prefer that we use %makeinstall, although I don't know if it's
required. I've been using it in all my spec files based on somebody's request.
* Don't install the generic INSTALL file.
* Remember to put version info for each changelog entry
rpmlint ../RPMS/i386/qsynth-0.2.5-2.i386.rpm
W: qsynth no-version-in-last-changelog
* I believe you should use the following before %configure...
unset QTDIR || : ; . /etc/profile.d/qt.sh
export QTLIB=${QTDIR}/lib QTINC=${QTDIR}/include
That's it for now. Thanks!
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list