[Bug 193933] Review Request: freepops - free webmails to pop3 daemon

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: freepops - free webmails to pop3 daemon


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193933





------- Additional Comments From bdpepple at ameritech.net  2006-06-08 14:30 EST -------
Here's a couple of quick items that need to be addressed:

1. Don't re-define %dist in your spec.
2. Inconsistant use of $RPM_BUILD_ROOT & %{buildroot}.  Pick one, and only use
that in your spec.
3. Why are your appending '.lsn' to the release?  If there is no good reason,
drop it.
4. Why are you defining the BuildArch?  If the package doesn't build on other
architectures, you should use the ExcludeArch.  Once the package is approved,
you will need to have a bug filed in bugzilla for each architecture, describing
the reason that the package does not compile/build/work on that architecture.
The bug number should then be placed in a comment, next to the corresponding
ExcludeArch line.  Until then, you will need to place the information in the
comments.
5. Drop both of the '%{__rm}' lines from the %prep section, they are unnecessary.

In the future, I would suggest using the Fedora spec template, because most of
these issues are addressed there.

As Hans pointed out in Comment #2, you must demonstrate an understanding of
Fedora Extras Packaging Guidelines, before you can be sponsored.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.