[Bug 193632] Review Request: tkdnd

bugzilla at redhat.com bugzilla at redhat.com
Thu Jun 8 18:52:26 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: tkdnd


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193632


wart at kobold.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From wart at kobold.org  2006-06-08 14:44 EST -------
> > SHOULD
> > ======
> > * You need BuildRequires: xorg-x11-devel if you plan to build on FC4.  You
> >   can do this by either forking the spec files in CVS, or adding the following
> >   to the current spec file:
> > %if "%fedora" <= "4"
> > BuildRequires:  xorg-x11-devel
> > %else
> > BuildRequires:  libXext-devel
> > %endif
> 
> Should I build on FC4? If yes, I think I will go for a fork.

It's up to you either way.  There's no requirement for you to build on FC4, and
you can always decide to do it later if you wish.
 
> > * An alpha release of version 2.0 is available.  Have you considered upgrading,
> >   or is the alpha version not stable enough?
> 
> I considered, but the alpha version is drop only, no drag yet.

Ok.

> > * Notify upstream about the 64-bit build issues and send them the patch.
> > 
> I think this makes more sence for 2.0 only since i don't think they will release
> another 1.x. I will check if 2.0 builds ok for 64-bit after I get my new
> computer (tomorrow).

That's understandable.  If you want to support both 1.0 and 2.0 being installed
simultaneously then you'll probably want to name the new package "tkdnd2",
otherwise yum will only let you have one installed at a time.

> Spec URL: http://amsn.hoentjen.eu/download/tkdnd.spec
> SRPM URL: http://amsn.hoentjen.eu/download/tkdnd-1.0a2-6.src.rpm

All MUSTFIX items have been fixed.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list