[Bug 193187] Review Request: pcsc-lite & ccid

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pcsc-lite & ccid


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193187





------- Additional Comments From rrelyea at redhat.com  2006-06-08 18:32 EST -------
Thanks for the quick review Ville.
I've now updated the packages (and removed some bottlenecks so I can turn them
around faster).

here's the diff between the CORE proposed packages and the current EXTRAS to aid
the review the only question I have is the %doc for reader.conf.d/README
correct, or does the %doc do some magic I'm not aware of:

--- /usr/src/redhat/SPECS/pcsc-lite.spec        2006-04-22 13:32:58.000000000 -0700
+++ ./pcsc-lite.spec    2006-06-08 09:02:14.253045000 -0700
@@ -1,6 +1,6 @@
 Name:           pcsc-lite
 Version:        1.3.1
-Release:        1%{?dist}
+Release:        2
 Summary:        PC/SC Lite smart card framework and applications

 Group:          System Environment/Daemons
@@ -13,7 +13,6 @@

 BuildRequires:  libusb-devel >= 0.1.7
 BuildRequires:  doxygen
-BuildRequires:  graphviz
 Requires(post): /sbin/chkconfig
 Requires(preun): /sbin/chkconfig
 Requires:       pcsc-ifd-handler
@@ -57,8 +56,6 @@
 %setup -q
 %patch0 -p0
 %patch1 -p1
-sed -i -e 's/^\(HAVE_DOT\s*=\s*\)/\1 YES/' doc/doxygen.conf.in
-

 %build
 %configure \
@@ -114,7 +111,7 @@
 %defattr(-,root,root,-)
 %doc AUTHORS ChangeLog* COPYING DRIVERS HELP README SECURITY TODO
 %dir %{_sysconfdir}/reader.conf.d/
-%{_sysconfdir}/reader.conf.d/README
+%doc %{_sysconfdir}/reader.conf.d/README
 %ghost %config %{_sysconfdir}/reader.conf
 %{_initrddir}/pcscd
 %{_bindir}/formaticc
@@ -142,6 +139,11 @@


 %changelog
+* Mon Jun 5 2006 Bob Relyea <rrelyea at redhat.com> - 1.3.1-2
+- Move to Fedora Core.
+- Remove dependency on graphviz.
+- Removed %%{_dist}
+
 * Sat Apr 22 2006 Ville Skyttä <ville.skytta at iki.fi> - 1.3.1-1
 - 1.3.1.

3c3
< Release:        2
---
> Release:        1%{?dist}
15a16
> BuildRequires:  graphviz
58a60,61
> sed -i -e 's/^\(HAVE_DOT\s*=\s*\)/\1 YES/' doc/doxygen.conf.in
>
114c117
< %doc %{_sysconfdir}/reader.conf.d/README
---
> %{_sysconfdir}/reader.conf.d/README
142,146d144
< * Mon Jun 5 2006 Bob Relyea <rrelyea at redhat.com> - 1.3.1-2
< - Move to Fedora Core.
< - Remove dependency on graphviz.
< - Removed %%{_dist}
<


--------------------------------
--- /usr/src/redhat/SPECS/ccid.spec     2006-04-22 13:33:57.000000000 -0700
+++ ./ccid.spec 2006-06-08 09:06:19.497820000 -0700
@@ -2,7 +2,7 @@

 Name:           ccid
 Version:        1.0.1
-Release:        1%{?dist}
+Release:        2
 Summary:        Generic USB CCID smart card reader driver

 Group:          System Environment/Libraries
@@ -61,6 +61,9 @@


 %changelog
+* Mon Jun  5 2006 Bob Relyea <rrelyea at redhat.com> - 1.0.1-2
+- Move to Fedora Core, removed %%{_dist}.
+
 * Sat Apr 22 2006 Ville Skyttä <ville.skytta at iki.fi> - 1.0.1-1
 - 1.0.1.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.