[Bug 191538] Review Request: qsynth - Qt based Fluidsynth GUI front end

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: qsynth - Qt based Fluidsynth GUI front end


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191538





------- Additional Comments From nando at ccrma.stanford.edu  2006-06-09 01:40 EST -------
New version:
Spec URL: http://ccrma.stanford.edu/planetccrma/extras/qsynth.spec
SRPM URL: http://ccrma.stanford.edu/planetccrma/extras/qsynth-0.2.5-3.src.rpm

(In reply to comment #1)
> Hi Fernando.  Here are some comments.  Some of these may seem nit-picky - sorry
> about that...

That's fine, some I will ignore :-)

> * Release should use %{?dist}

Fixed.

> * Some people prefer that we use %makeinstall, although I don't know if it's 
> required.  I've been using it in all my spec files based on somebody's request.

Sometimes it does not work, but in this it seems to be fine. 
 
> * Don't install the generic INSTALL file.

Fixed.

> * Remember to put version info for each changelog entry 
> rpmlint ../RPMS/i386/qsynth-0.2.5-2.i386.rpm
> W: qsynth no-version-in-last-changelog

Yes, I see, that was an internal release, it did not make sense to bump the
release so I did not put anything there. I can repeat the same number, I guess.
I have read that you have to always bump the release no matter what but in some
cases I think it is ridiculous (IMHO). 

> * I believe you should use the following before %configure...
> unset QTDIR || : ; . /etc/profile.d/qt.sh
> export QTLIB=${QTDIR}/lib QTINC=${QTDIR}/include

This I don't see the reason for. Just making sure that you pick the right QT? If
qt is properly installed qt.sh should run in the build system and set up all the
QT* variables. At least it does that for me (using mach). 

> That's it for now.  Thanks!

Tnks for taking the time to take a look. 

(In reply to comment #2)
> One more thing.. I tried this with VintageDreams soundfont, and found that I had
> to turn the gain down to 10 or less in order to stop the output from red-lining.
>  The gain setting defaults to 100.  Is this expected?

Hmmm, this I don't know. Which version of fluidsynth? I guess it depends on how
the soundfont was built, 10 seems a bit low. Where can I find the VintageDreams
soundfont to try it out?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.