[Bug 194436] Review Request: wormux - 2D Kill 'em all game
bugzilla at redhat.com
bugzilla at redhat.com
Fri Jun 9 20:17:35 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: wormux - 2D Kill 'em all game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194436
hugo at devin.com.br changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hugo at devin.com.br
------- Additional Comments From hugo at devin.com.br 2006-06-09 16:09 EST -------
My Review:
OKS
* Package's name is ok
* rpmlint returns ok
* Spec name is ok and legible in English
* License is ok and included in %doc
* Package's source matches upstream checksum
* Package builds fine
* BuildRequires are ok
* Package's %files are ok and all directories owned
* Package's %clean is ok
* Use of macros and scriptlets are fine
SHOULD
* Currently the package doesn't have locale files and the %find_lang macro
isn't necessary. But in the future this could change, so I think it should be
used from now
* You should create a sub-package to the data files, for example,
wormux-data. This will save the users' bandwidth when minor fixes are applied
to the main package.
* The description field is too vague. Try describing the game better ;-)
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list