[Bug 194730] Review Request: guichan - A Portable C++ GUI library for games using Allegro, SDL and OpenGL

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: guichan - A Portable C++ GUI library for games using Allegro, SDL and OpenGL


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194730





------- Additional Comments From wart at kobold.org  2006-06-10 00:44 EST -------
MUST
====
* name matches upstream
* BSD license ok, license file included
* Spec file legible and in Am. English
* Sources match upstream:
  f68b6c603c4fb3d70a8737f916214a35  guichan-0.4.0-src.tar.gz
* No excessive BR:
* Owns all directories that it creates
* No duplicate %files
* file permissions look ok
* Not relocatable
* ldconfig called where needed
* macro use consistent
* headers and unversioned .so files in -devel package
* RPM_BUILD_ROOT cleaned where needed
* No .la files
* no -doc subpackage needed
* devel require base using fully versioned dependency
* No .desktop file needed
* Compiles and builds on:
  FC4-i386, FC4-x86_64, FC5-i386, FC5-x86_64

MUSTFIX
=======
* Remove the leading 'A' from the summary
* Remove the empty Requires: line
* Add the following in %prep to prevent the trigger of calls to autoxxx:
touch aclocal.m4 Makefile.in */Makefile.in */*/Makefile.in */*/*/Makefile.in
touch include/config.hpp.in

QUESTIONS
=========
* why the 'cp -a' in %prep?  Just use %doc docs/html/* to pick up all of
  the files.

- Doesn't compile on FC-6 due to missing autoxxx.  The 'touch' commands
  above should fix that.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.