[Bug 194051] Review Request: abcMIDI - ABC to/from MIDI conversion utilities

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: abcMIDI - ABC to/from MIDI conversion utilities


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194051





------- Additional Comments From dan at danny.cz  2006-06-10 04:56 EST -------
the review is here

MUST
====
- no rpmlint output
- package name OK
- spec file name OK, is in English and is legible
- package meets the Packaging Guidelines
- license GPL and is included
- source matches upstream
- compiles and builds at least on i386
- no BuildRequires needed
- no localized files
- no shared libs
- no created directories and so no conflict with existing dirs
- no duplicates files, permissions are set properly, uses %defattr
- has %clean section
- consistent use of macros
- contains code
- no large docs, %doc is not required during runtime
- no need for devel subpackage
- not a GUI application

with the fix for the buffer overflow is this package APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.