[Bug 193342] Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines

bugzilla at redhat.com bugzilla at redhat.com
Sat Jun 10 13:41:01 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cegui - Free library providing windowing and widgets for graphics APIs / engines


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193342





------- Additional Comments From j.w.r.degoede at hhs.nl  2006-06-10 09:33 EST -------
Unfortunatly you missed a couple of 
-    hardcode_libdir_flag_spec='${wl}--rpath ${wl}$libdir'
+    hardcode_libdir_flag_spec='${wl}$libdir'
Which should be (as discussed):
-    hardcode_libdir_flag_spec='${wl}--rpath ${wl}$libdir'
+    hardcode_libdir_flag_spec=''
Cases, as said before just edit (or atleast read) the patch then they are easy
to spot. Even though these appearantly are in places where they don't get used
(otherwise ld would bomb out with an error) I would still like to see these fixed.

About SMC, my fixes have already been merged upstream, best to get the upstream
svn tree:
svn co http://opensvn.csie.org/SMC/SMC/
cd SMC
chmod +x autogen.sh configure
./autogen.sh
./configure --prefix=<whatever>
make
<enjoy>

Even though SMC isn't (IMHO) suitable for extras I would still like to see a
package I've asked upstream and upstream is willing to host fedora packages.
Will you create a SMC package or shall I?

Regarding creating an SMC package, upstream will do a new release with the
nescesarry Linux fixes soon.

One last note, please submit the 64 bit patches for DevIL and cegui (for cegui
also the tinyxml fix) upstream. Also it is probably a good idea to ask the cegui
people to add configure options / autodetects to use the system installed pcre
and tolua++ usually upstream package maintainers are willing to include things
like this to make our life easier if asked nicely :)


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list