[Bug 191014] Review Request: ganymed

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ganymed


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191014





------- Additional Comments From tibbs at math.uh.edu  2006-06-11 00:52 EST -------
Some observations:

There is absolutely no prohibition against using macros in your Source URLs; you
can use it if you like.  Folks who want to fetch the upstream source given your
specfile should use spectool -g.

The package builds fine in mock (x86_64, development).

rpmlint has a few complaints.  There are several description-line-too-long
warnings; you should reflow your %description to keep things down under 80
characters.

W: ganymed incoherent-version-in-changelog 209.2 209-2.fc6

Standard format is to separate version from release by a hyphen.

W: ganymed no-documentation

The source zip (zipball?) seems to have plenty of documentation. Is there some
reason it's not packaged?

The -debuginfo package generation seems to be confused; the build log is filled
with this:

extracting debug info from
/var/tmp/ganymed-209-2.fc6-root-mockbuild/usr/lib64/gcj/ganymed/ganymed-209.jar.so
cpio: ganymed-ssh2-build209/ch/ethz/ssh2/Connection$1$TimeoutState.java: No such
file or directory
cpio: ganymed-ssh2-build209/ch/ethz/ssh2/Connection$1.java: No such file or
directory
cpio: ganymed-ssh2-build209/ch/ethz/ssh2/Connection.java: No such file or directory

repeated once for each file in the "src" directory of the source zipball.  All
that ends up in the -debuginfo package are the symbols from the single .so.  I'm
not really sure what's supposed to happen here.  It seems like it's looking in
the wrong place; either that or something has deleted those files from the
buildroot before find-debuginfo.sh is run.

Other than those, I'd be happy approving this package.  I just want to make sure
 I'm on the right track and that I have enough basic understanding of how Java
packaging is supposed to work first.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.