[Bug 193929] Review Request: knetstats

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: knetstats


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193929





------- Additional Comments From cgoorah at yahoo.com.au  2006-06-11 16:55 EST -------
Hello Hans,
thanks for your remarks,

> Some (semi) initial remarks:
> -You BuildRequire qt-devel and you also BuildRequire kdelibs-devel, however
>  kdelibs-devel Requires qt-devel itself, so the BR qt-devel is redundant remove 

Removed.

>  please.
> -update-desktop-database is deprecated, remove please as well as the belongen
>  Requires(%post[un])
> -as already mentioned in comment #8 you must properly update the icon cache in
>  %post[un] see the wiki scriptlets page
> -don't call /sbin/ldconfig in %post[un] this package does not seem to contain
>  any libs

Updated to

%post
touch --no-create %{_datadir}/icons/hicolor || :

%postun
touch --no-create %{_datadir}/icons/hicolor || :

> -instead of:
>  ###
>  rm -rf $RPM_BUILD_ROOT%{_datadir}/applnk/Internet/%{name}.desktop
> 
>  desktop-file-install --vendor fedora \
>      --add-category Network \
>      --dir $RPM_BUILD_ROOT%{_datadir}/applnk/Internet/ \
>      %{name}.desktop
>  ###
>  use:
>  ###
>  desktop-file-install --vendor fedora \
>      --add-category X-Fedora \
>      --add-category Network \
>      --delete-original \
>      --dir $RPM_BUILD_ROOT%{_datadir}/applications/ \
>      $RPM_BUILD_ROOT%{_datadir}/applnk/Internet/%{name}.desktop
>  ###
>  Notice that the changed --dir, desktop files should be installed in
>  %{_datadir}/applications/ nowadays. Also notice the --delete-original
>  replacing the seperate rm command and last notice the additional
>  "--add-category X-Fedora" param which all fedora packages should use.
>  Also don't forget to update %files for the changed dir.
> 

done .

> 
> 
> > Nevertheless, I was unable to fix the
> > 
> > mkdir -p /usr/share/doc/HTML/en/knetstats && cd /usr/share/doc/HTML/en/knetstats
> > && rm -f common && ln -s ../common commonln: creating symbolic link `common' to
> > `../common': Permission denied
> > 
> > change the build so that it doesnot try to install files outside of the
> buildroot ?
> > How can I 
> 
> Okay, this is because of a dirty hack in upstreams sources, there are 2 possible
> fixes:
> 1) ignore the error (scons already does this) and add the following at the end 
>    of %install:
>    ln -s ../common $RPM_BUILD_ROOT%{_datadir}/doc/HTML/en/knetstats/common
> 2) patch admin/kde.py to properly honor DESTDIR.
> 

I was able to overcome that Permission Denied issue with 
%install
rm -fr $RPM_BUILD_ROOT
scons prefix=$RPM_BUILD_ROOT%{_prefix} install

but with rpmlint -i knetstats-1.5-5.i386.rpm, Ive fallen on
W: knetstats dangling-relative-symlink /usr/share/doc/HTML/en/knetstats/common
../common
The relative symbolic link points nowhere.

With f13's advice I've patched admin/kde.py accordingly.

Again with f13's advise, I've included scons as BR.

Updated:
Spec URL: http://beta.glwb.info/knetstats/knetstats.spec
SRPM URL: http://beta.glwb.info/knetstats/knetstats-1.5-5.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.